Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor] Fix displaying & editing project User Settings #2350

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

Basewq
Copy link
Contributor

@Basewq Basewq commented Jun 24, 2024

PR Details

[DataMember] makes the user settings appear again, probably was caused by #1875

Related Issue

Fixes #2347

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Eideren Eideren merged commit dbb125e into stride3d:master Jun 24, 2024
2 checks passed
@Eideren
Copy link
Collaborator

Eideren commented Jun 24, 2024

Yep, good catch, thanks !

@Basewq Basewq deleted the project_user_settings_fix branch June 24, 2024 23:36
@tebjan
Copy link
Member

tebjan commented Oct 25, 2024

This seems to be an issue again.

@tebjan
Copy link
Member

tebjan commented Oct 25, 2024

Nevermind, it works. The platform-specific project, e.g. MyGame.Windows needs to be selected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Effect Compiler/User Settings missing in Project property grid in the editor
4 participants