Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Refactor geometric primitive.cylinder to avoid GC #2369

Merged
merged 6 commits into from
Jul 6, 2024
Merged

perf: Refactor geometric primitive.cylinder to avoid GC #2369

merged 6 commits into from
Jul 6, 2024

Conversation

Arc-huangjingtong
Copy link
Contributor

PR Details

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Arc-huangjingtong
Copy link
Contributor Author

image
Test Success

@Eideren Eideren merged commit 6c467df into stride3d:master Jul 6, 2024
2 checks passed
@Eideren
Copy link
Collaborator

Eideren commented Jul 6, 2024

Thanks !

@Eideren Eideren changed the title Update : geometric primitive.cylinder to avoid GC perf: Refactor geometric primitive.cylinder to avoid GC Jul 6, 2024
@Arc-huangjingtong
Copy link
Contributor Author

You're welcome. I'm happy to help

@Kryptos-FR
Copy link
Member

Note for later: I see a lot of code-style change that don't conform to the rest of the code base and will likely be changed again the next time the file is touched. Please refrain form using your "preferred code style" and stick to what is currently present.

For instance, we never align statements by adding additional spaces before the = sign.

@Arc-huangjingtong
Copy link
Contributor Author

Arc-huangjingtong commented Jul 23, 2024

Note for later: I see a lot of code-style change that don't conform to the rest of the code base and will likely be changed again the next time the file is touched. Please refrain form using your "preferred code style" and stick to what is currently present.

For instance, we never align statements by adding additional spaces before the = sign.

Yes, I will remember

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants