Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change the error to a warning when searching for font path #2403

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

Jklawreszuk
Copy link
Collaborator

PR Details

This PR includes a fix for searching the font path on Linux. Previously when a font did not exist CompilerApp ignored the search for a default font, because of error.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built an engine and run the game to try this change out.

@Eideren Eideren merged commit 05901e0 into stride3d:master Aug 11, 2024
2 checks passed
@Eideren
Copy link
Collaborator

Eideren commented Aug 11, 2024

Looks good, thanks !

@Jklawreszuk Jklawreszuk deleted the fontpath-fix branch August 11, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants