Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Xml comments fix 5 #2419

Merged
merged 16 commits into from
Sep 1, 2024
Merged

Conversation

VaclavElias
Copy link
Contributor

PR Details

Fixing XML comments issues.

Related Issue

#1681

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@VaclavElias VaclavElias added the area-Doc Issues related to documentation and XML comments label Aug 25, 2024
Copy link
Collaborator

@Eideren Eideren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good, thanks a bunch @VaclavElias !

@VaclavElias
Copy link
Contributor Author

Let me do a few more commits regarding the docs reference https://doc.stride3d.net/latest/en/manual/graphics/low-level-api/textures-and-render-textures.html#scissor and then I will let you know when this can be merged.

@VaclavElias
Copy link
Contributor Author

@Eideren, the last commit fixed some of the broken <see cref=""/> tags. If all is ok, this can be merged. Thank you.

@Eideren Eideren merged commit 1cc9c24 into stride3d:master Sep 1, 2024
2 checks passed
@Eideren
Copy link
Collaborator

Eideren commented Sep 1, 2024

Thanks bud' !

@VaclavElias VaclavElias deleted the xml-comments-fix-5 branch September 22, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Doc Issues related to documentation and XML comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants