fix: Unable to Change CharacterComponent's collider shape properties without causing crash #2428
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Assigning a new
ColliderShape
intoCharacterComponent
and runningComposeShape()
causes a UAF related exception to be thrown. Related to an issue with theKinematicCharacter
reference inside of thediscreteDynamicWorld
in theSimulation
object.Solution would be to add additional setup to a overridden
ComposeShape()
method inside CharacterComponent. This setup would include the complete removal, reconstruction and reintegration of the KinematicCharacterController to the Simulation. Also added an additional function to try and maintain various physics properties onto theKinematicCharacter
such as Gravity, Fallspeed, etc.Related Issue
#2005
Types of changes
Checklist