-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gladiolus Rag fixes #223
Gladiolus Rag fixes #223
Conversation
wow! This looks so good! |
Thanks for calling this out — this part is very tricky. The next step is to make a small vexml integration test case reproducing that. I have a theory on what's broken. Beams assume that they will see all their notes before starting another beam. I know this because they are not keyed by anything in their underlying So far, I can think of doing one of the following solutions:
|
I'm glad you found this! Music notation is full of wonderful edge cases. |
This PR addresses some issues rendering Gladiolus Rag by Joplin in #78, but does not completely fix it.
StaveTie
height, part distance, or both.This PR adds basic support for rendering repeat barlines. I'll address alternative endings in lilypond 45b-RepeatWithAlternatives.xml.
Before
After