Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage, especially around caches. #12

Merged
merged 2 commits into from
Sep 14, 2017
Merged

Conversation

non
Copy link
Collaborator

@non non commented Sep 14, 2017

We still have coverage gaps in Rule.scala and Dag.scala, which will
have to be dealt with another time.

We still have coverage gaps in Rule.scala and Dag.scala, which will
have to be dealt with another time.
@non non requested a review from johnynek September 14, 2017 05:37
@codecov-io
Copy link

codecov-io commented Sep 14, 2017

Codecov Report

Merging #12 into master will increase coverage by 3.75%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12      +/-   ##
=======================================
+ Coverage   86.24%   90%   +3.75%     
=======================================
  Files          12    12              
  Lines         189   190       +1     
  Branches       15    15              
=======================================
+ Hits          163   171       +8     
+ Misses         26    19       -7
Impacted Files Coverage Δ
core/src/main/scala/com/stripe/dagon/HMap.scala 95.45% <100%> (+4.97%) ⬆️
core/src/main/scala/com/stripe/dagon/HCache.scala 100% <0%> (+42.85%) ⬆️
core/src/main/scala/com/stripe/dagon/Cache.scala 100% <0%> (+42.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8b5317...61058c5. Read the comment docs.

@johnynek
Copy link
Collaborator

👍

Thanks for the coverage.

@johnynek johnynek merged commit 0b963b1 into master Sep 14, 2017
@johnynek johnynek deleted the improve-coverage branch September 14, 2017 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants