Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Variadic Node #13

Merged
merged 2 commits into from
Sep 20, 2017
Merged

Add Variadic Node #13

merged 2 commits into from
Sep 20, 2017

Conversation

johnynek
Copy link
Collaborator

This allows us to deal with the not uncommon case (in data-flow optimization) of nodes that can consume any number of inputs.

@johnynek johnynek requested a review from non September 16, 2017 05:39
@non
Copy link
Collaborator

non commented Sep 16, 2017

Looks like we're maybe missing some cases. From Travis:

[info] ! Literal.Literal.evaluate must match simple explanation: Exception raised on property evaluation.
[info] > Exception: java.lang.IllegalArgumentException: oneOf called on empty collection

@johnynek
Copy link
Collaborator Author

johnynek commented Sep 16, 2017 via email

@johnynek
Copy link
Collaborator Author

generator was busted. Used a slightly broken transitive dependencies implementation.

@codecov-io
Copy link

codecov-io commented Sep 16, 2017

Codecov Report

Merging #13 into master will increase coverage by 0.45%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
+ Coverage      90%   90.45%   +0.45%     
==========================================
  Files          12       12              
  Lines         190      199       +9     
  Branches       15       17       +2     
==========================================
+ Hits          171      180       +9     
  Misses         19       19
Impacted Files Coverage Δ
core/src/main/scala/com/stripe/dagon/Dag.scala 94.39% <100%> (+0.39%) ⬆️
core/src/main/scala/com/stripe/dagon/Expr.scala 100% <100%> (ø) ⬆️
core/src/main/scala/com/stripe/dagon/Literal.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b963b1...1569c7f. Read the comment docs.

@johnynek
Copy link
Collaborator Author

good now @non ?

@erik-stripe
Copy link
Contributor

👍

@erik-stripe erik-stripe merged commit dab20e7 into master Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants