Fix an issue with rules introducing loops #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
==========================================
- Coverage 90.45% 90.29% -0.17%
==========================================
Files 12 12
Lines 199 206 +7
Branches 17 13 -4
==========================================
+ Hits 180 186 +6
- Misses 19 20 +1
Continue to review full report at Codecov.
|
non
reviewed
Oct 5, 2017
| // possibly lower the nextId, which is a bit | ||
| // nice because (unfortunately) Ids wrap Int | ||
| // not Long, so overflow is possible | ||
| val nextId = id2Exp.keySet.iterator.map(_.id).max |
There was a problem hiding this comment.
Might be nice to add something to HMap to make this more efficient, but we can do that later.
|
Seems reasonable to me. 👍 |
|
(NOTE: coverage only appears to go down due to one line that is an error about "unreachable code" so I think it's OK. We might want to annotate that line to not require coverage.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hit a bug using dagon with scalding where we have an explicit
Forknode in the AST. This node was originally to allow the user to hint that we consumed something more than once.It turns out to be convenient to use that in planning since in an early phase I could make all forks explicit, which simplifies writing the matching rules. However, this actually causes an infinite loop.
I added some tests to expose the bug, then fixed the issue.
I want to use this in scalding so I am hoping to publish a minor fix soon.