Add some more tests for HMap. #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At this point I think we're covering all the methods, certainly all the ones we are leaning on in the other code.
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
==========================================
+ Coverage 84.4% 86.09% +1.68%
==========================================
Files 12 12
Lines 186 187 +1
Branches 13 13
==========================================
+ Hits 157 161 +4
+ Misses 29 26 -3
Continue to review full report at Codecov.
|
johnynek
reviewed
Aug 30, 2017
| @@ -80,6 +83,6 @@ object HMap { | |||
| def empty[K[_], V[_]]: HMap[K, V] = | |||
| from[K, V](Map.empty[K[_], V[_]]) | |||
|
|
|||
| private def from[K[_], V[_]](m: Map[K[_], V[_]]): HMap[K, V] = | |||
| def from[K[_], V[_]](m: Map[K[_], V[_]]): HMap[K, V] = | |||
There was a problem hiding this comment.
do we have to make this public? This is unsafe and defeating the main use of the code (we know that the inner types match for the keys).
It looks like you are just using it to generate HMaps, but I think we can do that by doing .update with the right way, no?
There was a problem hiding this comment.
I'll make it private[dagon] -- I'm just using it in tests.
johnynek
approved these changes
Aug 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this point I think we're covering all the methods, certainly all
the ones we are leaning on in the other code.