Skip to content

Fix custom Connect response for Connect Request #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2024
Merged

Fix custom Connect response for Connect Request #28

merged 1 commit into from
Oct 17, 2024

Conversation

saurabhbhatia-stripe
Copy link

@saurabhbhatia-stripe saurabhbhatia-stripe commented Oct 17, 2024 •
edited
Loading

Summary

BUG - Go proxy creates HTTP/0.0 response instead of HTTP/1.0 while creating custom response.
Missed setting protoMajor and protoMinor in response object

	Status     string // e.g. "200 OK"
	StatusCode int    // e.g. 200
	Proto      string // e.g. "HTTP/1.0"
	ProtoMajor int    // e.g. 1
	ProtoMinor int    // e.g. 0

These changes only apply to ConnectAccept requests

@saurabhbhatia-stripe saurabhbhatia-stripe merged commit e12ef06 into master Oct 17, 2024
5 checks passed
@saurabhbhatia-stripe saurabhbhatia-stripe deleted the saurabhbhatia/custom-connect-response-fix branch October 17, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gauthamw-stripe gauthamw-stripe gauthamw-stripe approved these changes

Assignees

@gauthamw-stripe gauthamw-stripe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saurabhbhatia-stripe @gauthamw-stripe