Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize the ProtoRegistry API once go-protobuf's api-v2 lands #15

Open
jmillikin-stripe opened this issue Nov 27, 2018 · 2 comments
Open

Stabilize the ProtoRegistry API once go-protobuf's api-v2 lands #15

jmillikin-stripe opened this issue Nov 27, 2018 · 2 comments
Milestone
skycfg-1.0

Comments

@jmillikin-stripe
Copy link
Contributor

When the new proto.Message interface lands in a stable upstream release (golang/protobuf#364), we can use it for reflective operations instead of making assumptions about the generated struct layout. This is a hard requirement for a stable ProtoRegistry interface.
@jmillikin-stripe jmillikin-stripe added this to the skycfg-1.0 milestone Nov 27, 2018
@jmillikin-stripe
Copy link
Contributor Author

Looks like the new API has been released: https://blog.golang.org/a-new-go-api-for-protocol-buffers

@dilyevsky
Copy link
Contributor

dilyevsky commented Mar 2, 2020 •
edited
Loading

It seems like in order to be able to use the whole library needs to be converted to use new api and its https://google.golang.org/protobuf/types/dynamicpb

@jmillikin-stripe jmillikin-stripe mentioned this issue Jun 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
skycfg-1.0
Development

No branches or pull requests
2 participants
@dilyevsky @jmillikin-stripe