Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Phone number input not required even after setting configuration - AddressLauncher #9572

Closed
alvaro-delacruz-bat opened this issue Nov 7, 2024 · 3 comments
Labels

Comments

@alvaro-delacruz-bat
Copy link

alvaro-delacruz-bat commented Nov 7, 2024

Summary

While presenting the AddressLauncher, I noticed that the phone number field is not mandatory. Even after setting the following in the AddressLauncher.Configuration:

additionalFields = AddressLauncher.AdditionalFieldsConfiguration(
    phone = AddressLauncher.AdditionalFieldsConfiguration.FieldConfiguration.REQUIRED
 )

The optional label can be removed from the field, but the primaryButton remains enabled even when the field is empty or incomplete.

Code to reproduce

Just follow the official documentation to set up the address element.

Android version

Android 10,
Android 11,
Android 12,
Android 13,
Android 14,
Android 15

Impacted devices

Samsung,
Google Pixel

Installation method

Gradle dependency

Dependency Versions

kotlin:
stripe-android: 21.0.0
Android Gradle Plugin: 7.4.2
Gradle: 7.5

SDK classes

AddressLauncher

Video

Screen.Recording.2024-11-07.at.9.54.54.AM.mp4

Other information

N/A

@samer-stripe
Copy link
Collaborator

Hey @alvaro-delacruz-bat! This should be resolved by #9577 and should go out in the next release!

@alvaro-delacruz-bat
Copy link
Author

Gotcha, thanks @samer-stripe

@samer-stripe
Copy link
Collaborator

👋, the fix was released in v21.0.1. Please re-open the issue if the bug still occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants