-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Mockito from NetworkingLinkSignupViewModelTest
#9071
base: master
Are you sure you want to change the base?
Remove Mockito from NetworkingLinkSignupViewModelTest
#9071
Conversation
Diffuse output:
APK
|
dbeafaa
to
1d37d22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A test helper, since GetOrFetchSync
can not be a functional interface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A test helper, since SaveAccountToLink
can not be a functional interface (it has an email
and an sms
method).
1d37d22
to
d1a4f6c
Compare
d1a4f6c
to
bbd56c3
Compare
Summary
This pull request removes Mockito from
NetworkingLinkSignupViewModelTest
. It’s an example of how we should go about improving our unit tests going forward.Motivation
Testing
Screenshots
Changelog