Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remove button to update payment method screen #9593

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

amk-stripe
Copy link
Collaborator

@amk-stripe amk-stripe commented Nov 11, 2024

Summary

Add remove button to update payment method screen

Motivation

https://jira.corp.stripe.com/browse/MOBILESDK-2652

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screen recording

remove.button.webm

Copy link
Contributor

github-actions bot commented Nov 11, 2024

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 301.8 KiB │ 301.8 KiB │  0 B │ 455.5 KiB │ 455.5 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.1 KiB │   7.1 KiB │  0 B │   6.9 KiB │   6.9 KiB │  0 B 
    other │  90.2 KiB │  90.2 KiB │ +9 B │ 170.3 KiB │ 170.3 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ +9 B │  21.5 MiB │  21.5 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 19966 │ 19966 │ 0 (+0 -0) 
   types │  6188 │  6188 │ 0 (+0 -0) 
 classes │  4979 │  4979 │ 0 (+0 -0) 
 methods │ 29759 │ 29759 │ 0 (+0 -0) 
  fields │ 17526 │ 17526 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3622 │ 3622 │  0
APK
   compressed    │  uncompressed   │                        
──────────┬──────┼──────────┬──────┤                        
 size     │ diff │ size     │ diff │ path                   
──────────┼──────┼──────────┼──────┼────────────────────────
 25.3 KiB │ +5 B │ 62.8 KiB │  0 B │ ∆ META-INF/MANIFEST.MF 
 28.4 KiB │ +3 B │ 62.9 KiB │  0 B │ ∆ META-INF/CERT.SF     
  1.2 KiB │ +1 B │  1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA    
──────────┼──────┼──────────┼──────┼────────────────────────
 54.9 KiB │ +9 B │  127 KiB │  0 B │ (total)

@amk-stripe amk-stripe marked this pull request as ready for review November 11, 2024 23:47
@amk-stripe amk-stripe requested review from a team as code owners November 11, 2024 23:47
@amk-stripe amk-stripe requested review from toluo-stripe and samer-stripe and removed request for toluo-stripe November 11, 2024 23:47
samer-stripe
samer-stripe previously approved these changes Nov 12, 2024

Spacer(modifier = Modifier.requiredHeight(32.dp))

com.stripe.android.common.ui.PrimaryButton(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Can this be imported as an alias?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@amk-stripe amk-stripe merged commit abf4aee into master Nov 12, 2024
13 checks passed
@amk-stripe amk-stripe deleted the add-delete-button-to-update-card-screen branch November 12, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants