Refactor PaymentMethodRowButton to support embedded configurations

[tjclawson-stripe]

Summary

Refactor PaymentMethodRowButton to support embedded configurations.
Notes:

• Row separators will be handled by Embedded Payment Method Layout UI when implemented

Motivation

MOBILESDK-2626

Testing

• Added tests
• Modified tests
• Manually verified

[github-actions]

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 301.8 KiB │ 301.8 KiB │  0 B │ 455.5 KiB │ 455.5 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.1 KiB │   7.1 KiB │  0 B │   6.9 KiB │   6.9 KiB │  0 B 
    other │  90.2 KiB │  90.2 KiB │ +1 B │ 170.3 KiB │ 170.3 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ +1 B │  21.5 MiB │  21.5 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 19966 │ 19966 │ 0 (+0 -0) 
   types │  6188 │  6188 │ 0 (+0 -0) 
 classes │  4979 │  4979 │ 0 (+0 -0) 
 methods │ 29759 │ 29759 │ 0 (+0 -0) 
  fields │ 17526 │ 17526 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3622 │ 3622 │  0

APK

   compressed    │  uncompressed   │                        
──────────┬──────┼──────────┬──────┤                        
 size     │ diff │ size     │ diff │ path                   
──────────┼──────┼──────────┼──────┼────────────────────────
 28.4 KiB │ -8 B │ 62.9 KiB │  0 B │ ∆ META-INF/CERT.SF     
 25.3 KiB │ +8 B │ 62.8 KiB │  0 B │ ∆ META-INF/MANIFEST.MF 
  1.2 KiB │ +1 B │  1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA    
──────────┼──────┼──────────┼──────┼────────────────────────
 54.9 KiB │ +1 B │  127 KiB │  0 B │ (total)

[jaynewstrom-stripe]

I think we should do this a different way (any of these work for me):

• We should separate the shell from the content in a pure refactor, no new functionality. Just enabling the inner content to be used by some different outer content later on.
• We should merge in the appearance API first, then make these changes.
  I don't love having half baked code in the repo (TODOs aren't tracked anywhere!).

We also have a lot of opportunity to add screenshot tests here.

[jaynewstrom-stripe]

These radio buttons look massive. Do they match the spec?

[tjclawson-stripe]

They look equivalent to the ones in the design spec to me. I can make them smaller if desired. Do we have a figma with actual sizing?

[jaynewstrom-stripe]

Should this move below? It feels like we'd always want this max width, not optionally?

[jaynewstrom-stripe]

Why is the row needed? It looks like we can combine the modifiers with the card.

[jaynewstrom-stripe]

It looks like we do this for every variant. Can we move this logic into the RowButtonContent?

[jaynewstrom-stripe]

This is a little deceptive. Maybe a rename to paddingValuesForSubtitle would be better? (there's probably still a better name yet).

[jaynewstrom-stripe]

I thought we'd have a generic inner content item, and that would be used for all types. This makes it feel like you would have to change 3 places if you wanted to add something new to the inner content.

[jaynewstrom-stripe]

The spacing here looks wrong.

[jaynewstrom-stripe]

The designs are quite a bit different in figma.