Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ConfirmationHandler interface & nest confirmation types in handler interface. #9597

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

samer-stripe
Copy link
Collaborator

Summary

Create ConfirmationHandler interface & nest confirmation types in handler interface.

Motivation

Creates an interface which can be used for injecting various implementations of ConfirmationHandler in our products. Provides better testability and also better type isolation for confirmation.

Testing

  • Added tests
  • Modified tests
  • Manually verified

Copy link
Contributor

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 301.8 KiB │ 301.8 KiB │  0 B │ 455.5 KiB │ 455.5 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.1 KiB │   7.1 KiB │  0 B │   6.9 KiB │   6.9 KiB │  0 B 
    other │  90.2 KiB │  90.2 KiB │ -1 B │ 170.3 KiB │ 170.3 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ -1 B │  21.5 MiB │  21.5 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 19966 │ 19966 │ 0 (+0 -0) 
   types │  6188 │  6188 │ 0 (+0 -0) 
 classes │  4979 │  4979 │ 0 (+0 -0) 
 methods │ 29759 │ 29759 │ 0 (+0 -0) 
  fields │ 17526 │ 17526 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3622 │ 3622 │  0
APK
   compressed    │  uncompressed   │                        
──────────┬──────┼──────────┬──────┤                        
 size     │ diff │ size     │ diff │ path                   
──────────┼──────┼──────────┼──────┼────────────────────────
 28.4 KiB │ +3 B │ 62.9 KiB │  0 B │ ∆ META-INF/CERT.SF     
  1.2 KiB │ -2 B │  1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA    
 25.3 KiB │ -2 B │ 62.8 KiB │  0 B │ ∆ META-INF/MANIFEST.MF 
──────────┼──────┼──────────┼──────┼────────────────────────
 54.9 KiB │ -1 B │  127 KiB │  0 B │ (total)

@samer-stripe samer-stripe marked this pull request as ready for review November 12, 2024 14:44
@samer-stripe samer-stripe requested review from a team as code owners November 12, 2024 14:44
Copy link
Collaborator

@jaynewstrom-stripe jaynewstrom-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Looking forward to the testing improvements!

* This interface handles the confirmation process of a [StripeIntent] and/or external payment. This interface is
* intended to run only one confirmation process at a time.
*/
internal interface ConfirmationHandler {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@samer-stripe samer-stripe merged commit ac077fc into master Nov 12, 2024
13 checks passed
@samer-stripe samer-stripe deleted the samer/create-confirmation-handler-interface branch November 12, 2024 15:07
@samer-stripe samer-stripe added the embedded-confirmation Related to Embedded project in terms of confirmation work label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
embedded-confirmation Related to Embedded project in terms of confirmation work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants