[wip] Add an HTTP wrapper to the gRPC daemon #914
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The daemon can spin up an http grpc server in parallel for web clients * Go back to the non-hardcoded ip * Add comment for exported server function * Return the right header in the required header check for the daemon * When the request errors, mention both headers otherwise the logic gets weird * Remove extra newline Co-authored-by: Tomer Elmalem <tomer@stripe.com>
tomer-stripe
changed the title
Collaborator
Author
|
Closing this, very old |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers
r? @
cc @stripe/developer-products
Summary
do not merge
Original PR is #899. Revert in #913 because there's an open dependabot issue for an older version of gin-gonic that hasn't been updated in coder/websocket#345 (this can be merged once that's resolved or github.com/improbable-eng/grpc-web removes the websocket dependency entirely)