Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support starting the node proc with HTTPs support. #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jessp01
Copy link

@jessp01 jessp01 commented Mar 31, 2021

This is needed when you wish to use a non-test Stripe account [aka livemode] with registerWebhooks:true (the default) without setting up a proxy server/load balancer, since, if not running over HTTPs, the code will fail with:

Error registering webhook: StripeInvalidRequestError: Invalid URL: undefined/pilots/stripe/webhooks. URLs in livemode must begin with "https://"
    at Function.generate (/tmp/stripe-connect-custom-rocketdeliveries/node_modules/stripe/lib/Error.js:49:16)
    at IncomingMessage.<anonymous> (/tmp/stripe-connect-custom-rocketdeliveries/node_modules/stripe/lib/StripeResource.js:167:39)
    at Object.onceWrapper (events.js:420:28)
    at IncomingMessage.emit (events.js:326:22)
    at endReadableNT (_stream_readable.js:1241:12)
    at processTicksAndRejections (internal/process/task_queues.js:84:21) {
  raw: {
    message: 'Invalid URL: undefined/pilots/stripe/webhooks. URLs in livemode must begin with "https://"',
    type: 'invalid_request_error',

This is needed when you wish to use a non-test Stripe account with this app without setting up a proxy server/load balancer, since, if not running over HTTPs, 'real' interactions will fail.
@CLAassistant
Copy link

CLAassistant commented Mar 31, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Jess Portnoy seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants