Allow monkey patching http / https #1866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardm-stripe
approved these changes
Aug 2, 2023
Contributor
richardm-stripe
left a comment
richardm-stripe
left a comment
There was a problem hiding this comment.
LGTM, some suggestions about comments.
stripe-openapi bot
added a commit
that referenced
this pull request
Aug 3, 2023
* Update generated code for v434 * Update generated code for v435 * Update generated code for v436 * Update generated code for v437 * Update generated code for v438 * Allow monkey patching http / https (#1866) * allow monkey-patching http / https in ESM context * comment in tscsonfig * better comment * Update generated code for v441 * Update generated code for v442 * Update generated code for v443 * Update generated code for v444 * Update generated code for v444 * Update generated code for v445 * Update generated code for v446 --------- Co-authored-by: Stripe OpenAPI <105521251+stripe-openapi[bot]@users.noreply.github.com> Co-authored-by: anniel-stripe <97691964+anniel-stripe@users.noreply.github.com>
2 tasks
2 tasks
gurus00
pushed a commit
to gurus00/stripe-node
that referenced
this pull request
Feb 11, 2025
* allow monkey-patching http / https in ESM context * comment in tscsonfig * better comment
gurus00
pushed a commit
to gurus00/stripe-node
that referenced
this pull request
Feb 11, 2025
* allow monkey-patching http / https in ESM context * comment in tscsonfig * better comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Achieves a similar affect as #1854 (but without turning on the
esModuleInteropoption) to enable monkey patching of the 'http' / 'https' modules when importing stripe as an ES module.Also adds a test to prevent against future regressions, and makes
esModuleInterop: falseexplicit.Motivation: #1844