From 1297878c201d51d32cb733447449be3b8d902088 Mon Sep 17 00:00:00 2001 From: Olivier Bellone Date: Mon, 30 Oct 2017 19:21:23 +0100 Subject: [PATCH] Minor fixes --- stripe/api_resources/account.py | 7 ------- stripe/api_resources/customer.py | 8 -------- stripe/api_resources/invoice_item.py | 2 +- stripe/test/api_resources/test_balance.py | 7 +++++++ stripe/test/api_resources/test_invoice.py | 7 +++++++ stripe/util.py | 2 ++ 6 files changed, 17 insertions(+), 16 deletions(-) diff --git a/stripe/api_resources/account.py b/stripe/api_resources/account.py index d3ccde832..a5bdd1e94 100644 --- a/stripe/api_resources/account.py +++ b/stripe/api_resources/account.py @@ -54,10 +54,3 @@ def reject(self, reason=None, idempotency_key=None): def deauthorize(self, **params): params['stripe_user_id'] = self.id return oauth.OAuth.deauthorize(**params) - - @classmethod - def modify_external_account(cls, sid, external_account_id, **params): - url = "%s/%s/external_accounts/%s" % ( - cls.class_url(), urllib.quote_plus(util.utf8(sid)), - urllib.quote_plus(util.utf8(external_account_id))) - return cls._modify(url, **params) diff --git a/stripe/api_resources/customer.py b/stripe/api_resources/customer.py index 87e522ab9..19b912302 100644 --- a/stripe/api_resources/customer.py +++ b/stripe/api_resources/customer.py @@ -1,4 +1,3 @@ -import urllib import warnings from stripe import api_requestor, util @@ -79,10 +78,3 @@ def delete_discount(self, **params): url = self.instance_url() + '/discount' _, api_key = requestor.request('delete', url) self.refresh_from({'discount': None}, api_key, True) - - @classmethod - def modify_source(cls, sid, source_id, **params): - url = "%s/%s/sources/%s" % ( - cls.class_url(), urllib.quote_plus(util.utf8(sid)), - urllib.quote_plus(util.utf8(source_id))) - return cls._modify(url, **params) diff --git a/stripe/api_resources/invoice_item.py b/stripe/api_resources/invoice_item.py index cf08ca80b..a3e5ed820 100644 --- a/stripe/api_resources/invoice_item.py +++ b/stripe/api_resources/invoice_item.py @@ -6,4 +6,4 @@ class InvoiceItem(CreateableAPIResource, UpdateableAPIResource, ListableAPIResource, DeletableAPIResource): - OBJECT_NAME = 'invoice_item' + OBJECT_NAME = 'invoiceitem' diff --git a/stripe/test/api_resources/test_balance.py b/stripe/test/api_resources/test_balance.py index e68d8b93c..31820eec1 100644 --- a/stripe/test/api_resources/test_balance.py +++ b/stripe/test/api_resources/test_balance.py @@ -24,3 +24,10 @@ def test_list_balance_transactions(self): '/v1/balance/history', {} ) + + def test_convert_to_stripe_object(self): + transaction = stripe.util.convert_to_stripe_object({ + 'id': 'txn_foo', + 'object': 'balance_transaction', + }) + self.assertIsInstance(transaction, stripe.BalanceTransaction) diff --git a/stripe/test/api_resources/test_invoice.py b/stripe/test/api_resources/test_invoice.py index 094d7014c..9ecae3cd4 100644 --- a/stripe/test/api_resources/test_invoice.py +++ b/stripe/test/api_resources/test_invoice.py @@ -30,6 +30,13 @@ def test_retrieve_invoice_items(self): {'customer': 'cus_get_invoice_items'}, ) + def test_convert_to_stripe_object(self): + item = stripe.util.convert_to_stripe_object({ + 'id': 'ii_foo', + 'object': 'invoiceitem', + }) + self.assertIsInstance(item, stripe.InvoiceItem) + def test_invoice_create(self): customer = stripe.Customer(id="cus_invoice") stripe.Invoice.create(customer=customer.id) diff --git a/stripe/util.py b/stripe/util.py index 801a72bea..7ea4a0062 100644 --- a/stripe/util.py +++ b/stripe/util.py @@ -181,6 +181,8 @@ def load_object_classes(): api_resources.ApplicationFeeRefund.OBJECT_NAME: api_resources.ApplicationFeeRefund, api_resources.Balance.OBJECT_NAME: api_resources.Balance, + api_resources.BalanceTransaction.OBJECT_NAME: + api_resources.BalanceTransaction, api_resources.BankAccount.OBJECT_NAME: api_resources.BankAccount, api_resources.BitcoinReceiver.OBJECT_NAME: api_resources.BitcoinReceiver,