From 059181e103f49fe21fe7df2accfc8955f2781423 Mon Sep 17 00:00:00 2001 From: Remi Jannel Date: Tue, 30 Jul 2019 09:58:16 -0700 Subject: [PATCH] Move Balance History to /v1/balance_transactions and add tests --- .travis.yml | 2 +- stripe/api_resources/balance_transaction.py | 4 ---- tests/api_resources/test_balance_transaction.py | 9 ++++++++- tests/conftest.py | 2 +- 4 files changed, 10 insertions(+), 7 deletions(-) diff --git a/.travis.yml b/.travis.yml index 1cc1a96ee..3abd3f669 100644 --- a/.travis.yml +++ b/.travis.yml @@ -25,7 +25,7 @@ cache: env: global: # If changing this number, please also change it in `tests/conftest.py`. - - STRIPE_MOCK_VERSION=0.60.0 + - STRIPE_MOCK_VERSION=0.63.0 before_install: # Unpack and start stripe-mock so that the test suite can talk to it diff --git a/stripe/api_resources/balance_transaction.py b/stripe/api_resources/balance_transaction.py index 1cb224cf8..c1f1aeff9 100644 --- a/stripe/api_resources/balance_transaction.py +++ b/stripe/api_resources/balance_transaction.py @@ -5,7 +5,3 @@ class BalanceTransaction(ListableAPIResource): OBJECT_NAME = "balance_transaction" - - @classmethod - def class_url(cls): - return "/v1/balance/history" diff --git a/tests/api_resources/test_balance_transaction.py b/tests/api_resources/test_balance_transaction.py index d9417cce6..a05ccc1b3 100644 --- a/tests/api_resources/test_balance_transaction.py +++ b/tests/api_resources/test_balance_transaction.py @@ -9,6 +9,13 @@ class TestBalanceTransaction(object): def test_is_listable(self, request_mock): resources = stripe.BalanceTransaction.list() - request_mock.assert_requested("get", "/v1/balance/history") + request_mock.assert_requested("get", "/v1/balance_transactions") assert isinstance(resources.data, list) assert isinstance(resources.data[0], stripe.BalanceTransaction) + + def test_is_retrievable(self, request_mock): + resource = stripe.BalanceTransaction.retrieve(TEST_RESOURCE_ID) + request_mock.assert_requested( + "get", "/v1/balance_transactions/%s" % TEST_RESOURCE_ID + ) + assert isinstance(resource, stripe.BalanceTransaction) diff --git a/tests/conftest.py b/tests/conftest.py index fb358c4a2..eb0f3783a 100644 --- a/tests/conftest.py +++ b/tests/conftest.py @@ -16,7 +16,7 @@ # When changing this number, don't forget to change it in `.travis.yml` too. -MOCK_MINIMUM_VERSION = "0.60.0" +MOCK_MINIMUM_VERSION = "0.63.0" # Starts stripe-mock if an OpenAPI spec override is found in `openapi/`, and # otherwise fall back to `STRIPE_MOCK_PORT` or 12111.