Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCPCancelable completion is not getting called #103

Open
hanumanAbacus opened this issue Aug 11, 2021 · 4 comments
Open

SCPCancelable completion is not getting called #103

hanumanAbacus opened this issue Aug 11, 2021 · 4 comments
Labels
bug Bug report P3

Comments

@hanumanAbacus
Copy link

Summary

Call of cancel on SCPCancelable, completion is not called

Code to reproduce

iOS version

14

Installation method

pod

SDK version

2.0.1

Other information

Call processPayment
tap to card to authorise
disconnect the bluetooth on iPad
the terminal shows disconnected
turn on the bluetooth on iPad, the terminal reconnects
call cancel on collectPaymentMethod SCPCancelable object. The completion is not called back, either with error or nil

@bric-stripe
Copy link
Collaborator

thanks for the report, I'd expect those steps to immediately call back with an error of SCPErrorCancelFailedAlreadyCompleted. will try to reproduce and get this fixed.

@bric-stripe
Copy link
Collaborator

hey, reviewing stale issues and realized this one can still happen, though I think the repro steps mentioned should be working now. But from reviewing the code there are still cases where cancelable's could send a message to an instance that was nil'd and would never call the completion. Created an internal ticket to better track this but still not sure when it would be prioritized.

@MMavrisPaleBlue
Copy link

Is this solved? I am getting the same behaviour

@bric-stripe
Copy link
Collaborator

@MMavrisPaleBlue no this is still an open issue that hasn't been prioritized. Are you hitting it with the same repro steps from the summary? Or different repro steps? What version? The repro steps from the summary should be fixed in newer versions but there are still edge cases where the completion may not be called if the command that provided the completion had already completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report P3
Projects
None yet
Development

No branches or pull requests

3 participants