Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spinner for streaming looks frozen #252

Closed
gracegoo-stripe opened this issue Jun 7, 2021 · 10 comments
Closed

Spinner for streaming looks frozen #252

gracegoo-stripe opened this issue Jun 7, 2021 · 10 comments
Assignees
Milestone

Comments

@gracegoo-stripe
Copy link
Contributor

The spinner for the logs and events streaming looks like it's frozen because it just displays one frame (or the same frame over and over again) until the streaming actually starts. Look into see if this is something we can fix.

@gracegoo-stripe gracegoo-stripe added this to the GA milestone Jun 7, 2021
@vcheung-stripe
Copy link
Collaborator

@vcheung-stripe
Copy link
Collaborator

Or better, looks like it can be done without a custom SVG: microsoft/vscode#117859

@gracegoo-stripe gracegoo-stripe self-assigned this Jun 7, 2021
@gracegoo-stripe
Copy link
Contributor Author

The spinner looks wonky with the version of the vscode engine we have -- we'll need to update the min version of vscode

@gracegoo-stripe
Copy link
Contributor Author

Actually, this update may not be out yet

@gracegoo-stripe
Copy link
Contributor Author

gracegoo-stripe commented Jun 7, 2021

Meanwhile, we can use a custom SVG or update the padding ourselves for now -- I'll probably do the latter

@gracegoo-stripe
Copy link
Contributor Author

gracegoo-stripe commented Jun 7, 2021

I don't know if we can manipulate the css of the pane from our extension.. But, it looks like the expected release date that includes this update is expected to be on June 9th: microsoft/vscode#125031. I'd say it's worth waiting for that.

@vcheung-stripe
Copy link
Collaborator

We can probably merge this now without waiting for the next VS Code update. Even if we wait, users on older VS Code versions will still see the wonky spinner.

@gracegoo-stripe
Copy link
Contributor Author

You're right, I initially thought that if we upgrade the engine the user would get prompted to update their VSCode but it looks like it's the other way around and they don't get prompted for our extension upgrade unless they are on a newer version.

gracegoo-stripe added a commit that referenced this issue Jun 10, 2021
The loading icon from the vscode catalog does not work well with the spin animation.
This will be fixed in an upcoming release so we can eventually remove this.

More details here: #252
gracegoo-stripe added a commit that referenced this issue Jun 11, 2021
The loading icon from the vscode catalog does not work well with the spin animation.
This will be fixed in an upcoming release so we can eventually remove this.

More details here: #252
gracegoo-stripe added a commit that referenced this issue Jun 11, 2021
The loading icon from the vscode catalog does not work well with the spin animation.
This will be fixed in an upcoming release so we can eventually remove this.

More details here: #252
@vcheung-stripe
Copy link
Collaborator

Can this be closed?

@gracegoo-stripe
Copy link
Contributor Author

Yup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants