-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spinner for streaming looks frozen #252
Comments
Here's how it's done in Azure extensions. It looks like they include a custom SVG: https://github.com/microsoft/vscode-azuretools/blob/6d242c5132c2d11b21e6d7d2e6cc6629aa2dbfa1/ui/src/tree/AzureAccountTreeItemBase.ts#L98 |
Or better, looks like it can be done without a custom SVG: microsoft/vscode#117859 |
The spinner looks wonky with the version of the vscode engine we have -- we'll need to update the min version of vscode |
Actually, this update may not be out yet |
Meanwhile, we can use a custom SVG or update the padding ourselves for now -- I'll probably do the latter |
I don't know if we can manipulate the css of the pane from our extension.. But, it looks like the expected release date that includes this update is expected to be on June 9th: microsoft/vscode#125031. I'd say it's worth waiting for that. |
We can probably merge this now without waiting for the next VS Code update. Even if we wait, users on older VS Code versions will still see the wonky spinner. |
You're right, I initially thought that if we upgrade the engine the user would get prompted to update their VSCode but it looks like it's the other way around and they don't get prompted for our extension upgrade unless they are on a newer version. |
The loading icon from the vscode catalog does not work well with the spin animation. This will be fixed in an upcoming release so we can eventually remove this. More details here: #252
The loading icon from the vscode catalog does not work well with the spin animation. This will be fixed in an upcoming release so we can eventually remove this. More details here: #252
The loading icon from the vscode catalog does not work well with the spin animation. This will be fixed in an upcoming release so we can eventually remove this. More details here: #252
Can this be closed? |
Yup |
The spinner for the logs and events streaming looks like it's frozen because it just displays one frame (or the same frame over and over again) until the streaming actually starts. Look into see if this is something we can fix.
The text was updated successfully, but these errors were encountered: