Feature/support header param #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the jsdoc for SharedMethod constructor to describe this new options - see #88. For the sake of completeness, it would be nice to support |
raymondfeng
force-pushed
the
feature/support-header-param
branch
from
c61b9b1 to
f4000d0
Compare
|
@bajtos JSdoc updated. I think it's useful to support response headers but I'll defer the implementation. |
I am fine with that as long as the documentation makes it clear that the |
| req.headers = req.headers || {}; | ||
| req.headers[name] = val; | ||
| } | ||
| break; |
There was a problem hiding this comment.
This is not covered by any unit-test, is it?
|
LGTM. |
raymondfeng
added a commit
that referenced
this pull request
Sep 19, 2014
Feature/support header param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/to @ritch