From 49e3cbf811017cfc40db7c170c612c5803ec054f Mon Sep 17 00:00:00 2001 From: Dirk Farin Date: Thu, 30 Mar 2023 20:31:35 +0200 Subject: [PATCH] add comment why we free the input image early (#801) --- libheif/plugins/heif_encoder_aom.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libheif/plugins/heif_encoder_aom.cc b/libheif/plugins/heif_encoder_aom.cc index 57d512d2ca..5baa8db1c3 100644 --- a/libheif/plugins/heif_encoder_aom.cc +++ b/libheif/plugins/heif_encoder_aom.cc @@ -1023,7 +1023,11 @@ struct heif_error aom_encode_image(void* encoder_raw, const struct heif_image* i // --- encode frame err = encode_frame(encoder, &codec, &input_image); //, frame_count++, flags, writer); + + // Note: we are freeing the input image directly after use. + // This covers the usual success case and also all error cases that occur below. aom_img_free(&input_image); + if (err.code != heif_error_Ok) { return err; }