Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terratest: Basic usage test #23

Merged
merged 7 commits into from
Mar 24, 2019
Merged

Terratest: Basic usage test #23

merged 7 commits into from
Mar 24, 2019

Conversation

jlsan92
Copy link
Contributor

@jlsan92 jlsan92 commented Mar 11, 2019

This is the beginning of tests use cases using Terratest 👍

So far, the only test ensures that the module is deployable using basic settings (described in the basic example).

I've faced many issues learning Golang (and its module's resolution) and I'm not happy how the go test command looks like inside the TravisCI config, so probably some help would be great 🙏

EDIT: Thanks @honzahovorka @varholak-peter for the help with the go modules 🍻

Closes: #11

@jlsan92 jlsan92 added the help wanted Extra attention is needed label Mar 11, 2019
@jlsan92 jlsan92 self-assigned this Mar 11, 2019
@jlsan92
Copy link
Contributor Author

jlsan92 commented Mar 12, 2019

As expected, adding this basic test, some bugs were found 😄 but now they are fixed and included in this PR

1 - Internal Module AWS region: The AWS region is used in some policies/interpolation files and by default it was us-east-1 (exposed as a variable). Now the variable is set to "" and the region used internally is the same used by the provider invoking the module. If for some reason you need to use a different region, the variable region needs to be explicitly set now.

2 - ALB's public subnets: All the Public Subnets generated by the VPC module were attached to the Internet-facing Load Balancer but if there is at least more than one subnet repeating AZs, the ALB couldn't be created. This is the case for some regions like São Paulo 🇧🇷that (in this moment) only has 2 AZs. So now, the number of subnets attached to the ALB is less or equal to the number of AZs in the current region

👍

@jlsan92 jlsan92 removed the help wanted Extra attention is needed label Mar 14, 2019
@jlsan92 jlsan92 mentioned this pull request Mar 21, 2019
3 tasks
@jlsan92 jlsan92 merged commit ad7cd36 into master Mar 24, 2019
@jlsan92 jlsan92 deleted the feature/terratest branch March 24, 2019 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant