Add PlatformSliverAppBar class with example #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bookshiyi
commented
Jul 15, 2023
Comment on lines
+261
to
+297
| //! Copied from file: /opt/homebrew/Caskroom/flutter/3.10.0/flutter/packages/flutter/lib/src/cupertino/nav_bar.dart | ||
| const Color _kDefaultNavBarBorderColor = Color(0x4D000000); | ||
|
|
||
| const Border _kDefaultNavBarBorder = Border( | ||
| bottom: BorderSide( | ||
| color: _kDefaultNavBarBorderColor, | ||
| width: 0.0, // 0.0 means one physical pixel | ||
| ), | ||
| ); | ||
|
|
||
| const _HeroTag _defaultHeroTag = _HeroTag(null); | ||
|
|
||
| @immutable | ||
| class _HeroTag { | ||
| const _HeroTag(this.navigator); | ||
|
|
||
| final NavigatorState? navigator; | ||
|
|
||
| // Let the Hero tag be described in tree dumps. | ||
| @override | ||
| String toString() => | ||
| 'Default Hero tag for Cupertino navigation bars with navigator $navigator'; | ||
|
|
||
| @override | ||
| bool operator ==(Object other) { | ||
| if (identical(this, other)) { | ||
| return true; | ||
| } | ||
| if (other.runtimeType != runtimeType) { | ||
| return false; | ||
| } | ||
| return other is _HeroTag && other.navigator == navigator; | ||
| } | ||
|
|
||
| @override | ||
| int get hashCode => identityHashCode(navigator); | ||
| } |
There was a problem hiding this comment.
Regarding these local variables, I didn't find a better solution, so I had to copy and paste them here intact.
|
Could you rebase. Sorry for the time it has taken to review |
aqwert
requested changes
Jan 24, 2024
The conflicts have been resolved without rebase. How do you think about this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by PR #425.