Skip to content
This repository has been archived by the owner on Jun 30, 2024. It is now read-only.

Remove support for styled(Component)(` #446

Open
oliviertassinari opened this issue May 28, 2024 · 1 comment
Open

Remove support for styled(Component)(` #446

oliviertassinari opened this issue May 28, 2024 · 1 comment

Comments

@oliviertassinari
Copy link

Describe the bug (including copyable syntax)

Today vscode-styled-components highlights the styled(Component)( pattern

SCR-20240528-oyqe

like it does with the styled(Component)` pattern:

SCR-20240528-oyrq

But should it?

Expected behavior

No highlights of the styled(Component)` pattern, per hudochenkov/postcss-styled-syntax#30 (comment)

Build environment (please complete the following information):

  • OS: macOS
  • VSCode Version: 1.89.1
  • Extension Version 1.7.8
@jasonwilliams
Copy link
Collaborator

jasonwilliams commented May 31, 2024

I see, this should be a straight forward fix to be honest so please have a stab at it. (I don't have time to contribute to this project anymore but I can help)

I would assume this is adjusting the regex here or here until it doesn't do that.

There is a contributing guide here (follow the syntax section).

But to be honest, it should be as simple as loading this into regex101 and fiddling about with it until it doesn't match, then add it back in and check tests still pass.

This is a good starting point: https://regex101.com/r/RmDFJ8/1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants