From 74f3c080f20302c724659aaac24d47fcc713ab49 Mon Sep 17 00:00:00 2001 From: Masafumi Koba <473530+ybiquitous@users.noreply.github.com> Date: Fri, 13 Dec 2024 09:25:05 +0900 Subject: [PATCH] Fix `at-rule-property-required-list` message to use "descriptor" for accuracy (#8186) Follow-up PR #8185 See also Note that it doesn't rename local variables to minimize code diffs and keep git-blame easy. --- .changeset/blue-carrots-share.md | 5 +++++ lib/rules/at-rule-property-required-list/index.cjs | 4 +++- lib/rules/at-rule-property-required-list/index.mjs | 4 +++- 3 files changed, 11 insertions(+), 2 deletions(-) create mode 100644 .changeset/blue-carrots-share.md diff --git a/.changeset/blue-carrots-share.md b/.changeset/blue-carrots-share.md new file mode 100644 index 0000000000..09b574f618 --- /dev/null +++ b/.changeset/blue-carrots-share.md @@ -0,0 +1,5 @@ +--- +"stylelint": patch +--- + +Fixed: `at-rule-property-required-list` message to use "descriptor" for accuracy diff --git a/lib/rules/at-rule-property-required-list/index.cjs b/lib/rules/at-rule-property-required-list/index.cjs index 708e3f3300..b748971200 100644 --- a/lib/rules/at-rule-property-required-list/index.cjs +++ b/lib/rules/at-rule-property-required-list/index.cjs @@ -10,10 +10,12 @@ const ruleMessages = require('../../utils/ruleMessages.cjs'); const validateObjectWithArrayProps = require('../../utils/validateObjectWithArrayProps.cjs'); const validateOptions = require('../../utils/validateOptions.cjs'); +// NOTE: We should have named this rule as `at-rule-descriptor-required-list` instead. +// See https://github.com/stylelint/stylelint/pull/8185 const ruleName = 'at-rule-property-required-list'; const messages = ruleMessages(ruleName, { - expected: (atRule, property) => `Expected property "${property}" for at-rule "${atRule}"`, + expected: (atRule, descriptor) => `Expected descriptor "${descriptor}" for at-rule "${atRule}"`, }); const meta = { diff --git a/lib/rules/at-rule-property-required-list/index.mjs b/lib/rules/at-rule-property-required-list/index.mjs index 3ef2bdefa1..04715a3887 100644 --- a/lib/rules/at-rule-property-required-list/index.mjs +++ b/lib/rules/at-rule-property-required-list/index.mjs @@ -6,10 +6,12 @@ import ruleMessages from '../../utils/ruleMessages.mjs'; import validateObjectWithArrayProps from '../../utils/validateObjectWithArrayProps.mjs'; import validateOptions from '../../utils/validateOptions.mjs'; +// NOTE: We should have named this rule as `at-rule-descriptor-required-list` instead. +// See https://github.com/stylelint/stylelint/pull/8185 const ruleName = 'at-rule-property-required-list'; const messages = ruleMessages(ruleName, { - expected: (atRule, property) => `Expected property "${property}" for at-rule "${atRule}"`, + expected: (atRule, descriptor) => `Expected descriptor "${descriptor}" for at-rule "${atRule}"`, }); const meta = {