Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hacken 2022-12-21 Low #10,11] Comment Contradiction #76

Closed
zlace0x opened this issue Dec 22, 2022 · 1 comment · Fixed by #70
Closed

[Hacken 2022-12-21 Low #10,11] Comment Contradiction #76

zlace0x opened this issue Dec 22, 2022 · 1 comment · Fixed by #70

Comments

@zlace0x
Copy link
Contributor

zlace0x commented Dec 22, 2022

The comment in the _fallback() function contradicts the code: “delegatecall ...”.
In the code, the staticcall is used, which is correct.

Path:
./src/Funnel.sol : initialize()

Recommendation: Remove the contradiction in the comment.

Status: Reported (Replace the “delegatecall” with “staticcall” in comment in Line 326)

@zlace0x zlace0x linked a pull request Dec 22, 2022 that will close this issue
@zlace0x
Copy link
Contributor Author

zlace0x commented Dec 22, 2022

The comment on Line 42 of the IERC5827 interface is misplaced.

Path:
./src/interfaces/IERC5827.sol

Recommendation: Correct the misplacement.

Status: Reported (Move comment from Line 42 to Line 51)

@zlace0x zlace0x changed the title [Hacken 2022-12-21 Low #10] Comment Contradiction [Hacken 2022-12-21 Low #10,11] Comment Contradiction Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant