New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hacken 2022-12-21 Low #17] Unindexed Events #78

Closed

zlace0x opened this issue Dec 22, 2022 · 1 comment · Fixed by #70

Contributor

zlace0x commented Dec 22, 2022

Having indexed event parameters makes it easier to search for these events using indexed event parameters as filters.

Path:
./src/lib/NativeMetaTransaction.sol : MetaTransactionExecuted()

Recommendation: The “indexed” keyword should be used for the event parameters.

Status: Reported (Consider also indexing relayerAddress)

Contributor Author

zlace0x commented Dec 22, 2022

This incur additional 200 gas to index address.

zlace0x linked a pull request

that will close this issue

Fix/audits 4 #70

Merged

zlace0x closed this as completed in #70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment