Skip to content

Releases: suberra/funnel-contracts

Audit Revision v0.4.0-alpha

28 Jan 09:23
Compare
Choose a tag to compare

Changelog:

  • Fixed #81: Overflow on multiplication

Audit Revision v0.3.0-alpha

23 Dec 08:21
ef43c66
Compare
Choose a tag to compare
Pre-release

Addresses issues in audit report (2nd revision)

Fixed:

Wont-fix:

  • #71 H03: Data Consistency
    Reason: Intended behaviour. Checking ERC20 allowance is out of scope of Funnel as it is solely responsible for the additional check on renewable allowance. Also, the extra gas cost does not justify the additional check when Funnel are meant to be used after allowance is delegated to the funnel. Finally, the ERC20 allowance is already checked and thrown by the underlying ERC20 token.

  • #75 L04: Style Guide Violation
    Reason: Following the semantic meaning of variables.
    INITIAL_CHAIN_ID and INITIAL_DOMAIN_SEPARATOR are both semantically constants.

Audit Revision v0.2.0-alpha

13 Dec 14:20
Compare
Choose a tag to compare
Pre-release

Address all issued raised in audit report

Changelog

  • Removed solmate dependency (fixes #31, #33, #37)
  • fix: overflow situation #30
  • fix: data consistency #32
  • fix: unchecked transfer #34
  • fix: check-effects-interaction #35
  • refactor: standard to revert with custom errors (#47)
  • refactor: standardise Pragma version #36
  • refactor: style guide & function modifiers (#45 #39 #46 #44)
  • style: finished NatSpec #53
  • tests: negative cases (#57 #42)

Audit Revision

22 Nov 09:24
Compare
Choose a tag to compare
Audit Revision Pre-release
Pre-release

Changelog

  • refactor: standardise explicit imports
  • refactor: create2 static deployments
  • docs: fix IERC5827Spender params
  • feat: use safeTransferFrom
  • fix: return false on baseToken() call failure

Audit v0.1.0

17 Nov 08:56
Compare
Choose a tag to compare
Audit v0.1.0 Pre-release
Pre-release

First audit submission