Skip to content

Audit Revision v0.3.0-alpha

Pre-release
Pre-release
Compare
Choose a tag to compare
@zlace0x zlace0x released this 23 Dec 08:21
· 14 commits to main since this release
v0.3.0-alpha
ef43c66
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Learn about vigilant mode.

Addresses issues in audit report (2nd revision)

Fixed:

Wont-fix:

  • #71 H03: Data Consistency
    Reason: Intended behaviour. Checking ERC20 allowance is out of scope of Funnel as it is solely responsible for the additional check on renewable allowance. Also, the extra gas cost does not justify the additional check when Funnel are meant to be used after allowance is delegated to the funnel. Finally, the ERC20 allowance is already checked and thrown by the underlying ERC20 token.

  • #75 L04: Style Guide Violation
    Reason: Following the semantic meaning of variables.
    INITIAL_CHAIN_ID and INITIAL_DOMAIN_SEPARATOR are both semantically constants.

Assets 2
Loading