-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LeaderElectionSupport for unit testing #764
Add LeaderElectionSupport for unit testing #764
Conversation
Refactored from the submariner project for reuse. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
🤖 Created branch: z_pr764/tpantelis/leader_election_test_support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn’t the various Await
timeouts take the configured timeouts into account?
|
Right, I’m not interested in verifying the leader election code itself; my concern was to avoid issues with tests in scenarios where the tests themselves set up specific timeouts (whether longer or short than we expect). If the timeouts involved here are internal to the leader election that’s fine. |
Signed-off-by: Thomas Pantelis <tompantelis@gmail.com>
🤖 Closed branches: [z_pr764/tpantelis/leader_election_test_support] |
Refactored from the submariner project for reuse.
Related to submariner-io/submariner#2747