Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subctl should ask for confirmation before degrading OCP clusters #167

Closed
skitt opened this issue Feb 12, 2020 · 1 comment · Fixed by #222 or #226
Closed

subctl should ask for confirmation before degrading OCP clusters #167

skitt opened this issue Feb 12, 2020 · 1 comment · Fixed by #222 or #226
Assignees
@skitt
Labels
lighthouse subctl Subctl related issues
Milestone
v0.1.1

Comments

@skitt
Copy link
Member

skitt commented Feb 12, 2020

Deploying service discovery on OCP involves disabling the cluster version operator, which means upgrades are no longer applied. Before doing this, subctl should ask the user for confirmation.
@skitt skitt self-assigned this Feb 12, 2020
@skitt skitt added the subctl Subctl related issues label Feb 12, 2020
@mangelajo mangelajo added this to the v0.1.0 milestone Feb 13, 2020
@mangelajo mangelajo modified the milestones: v0.1.0, v0.1.1 Feb 24, 2020
skitt added a commit to skitt/submariner-operator that referenced this issue Mar 2, 2020
@skitt
Ask for confirmation before disabling OpenShift CVO
fc7091b 
When subctl join is run against an OpenShift cluster with a deployed
cluster version operator, and service discovery is enabled, we now ask
for confirmation before continuing, because installing service
discovery will disable the CVO.

Fixes: submariner-io#167
Signed-off-by: Stephen Kitt <skitt@redhat.com>
@skitt skitt mentioned this issue Mar 2, 2020
Merged
skitt added a commit to skitt/submariner-operator that referenced this issue Mar 2, 2020
@skitt
Ask for confirmation before disabling OpenShift CVO
a0ae575 
When subctl join is run against an OpenShift cluster with a deployed
cluster version operator, and service discovery is enabled, we now ask
for confirmation before continuing, because installing service
discovery will disable the CVO.

Fixes: submariner-io#167
Signed-off-by: Stephen Kitt <skitt@redhat.com>
skitt added a commit to skitt/submariner-operator that referenced this issue Mar 2, 2020
@skitt
Ask for confirmation before disabling OpenShift CVO
f3997bb 
When subctl join is run against an OpenShift cluster with a deployed
cluster version operator, and service discovery is enabled, we now ask
for confirmation before continuing, because installing service
discovery will disable the CVO.

Fixes: submariner-io#167
Signed-off-by: Stephen Kitt <skitt@redhat.com>
@mangelajo mangelajo linked a pull request Mar 4, 2020 that will close this issue
Ask for confirmation before disabling OpenShift CVO #222
Merged
skitt added a commit that referenced this issue Mar 4, 2020
@skitt
Ask for confirmation before disabling OpenShift CVO
9b6b450 
When subctl join is run against an OpenShift cluster with a deployed
cluster version operator, and service discovery is enabled, we now ask
for confirmation before continuing, because installing service
discovery will disable the CVO.

Fixes: #167
Signed-off-by: Stephen Kitt <skitt@redhat.com>
@mangelajo
Copy link
Contributor

The corresponding PR was merged, closing this :-)

skitt added a commit to skitt/submariner-operator that referenced this issue Mar 4, 2020
@skitt
Ask for confirmation before disabling OpenShift CVO
7f26731 
When subctl join is run against an OpenShift cluster with a deployed
cluster version operator, and service discovery is enabled, we now ask
for confirmation before continuing, because installing service
discovery will disable the CVO.

Fixes: submariner-io#167
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit 9b6b450)
@skitt skitt mentioned this issue Mar 4, 2020
Merged
mangelajo pushed a commit that referenced this issue Mar 4, 2020
@skitt @mangelajo
Ask for confirmation before disabling OpenShift CVO
ce7f9ad 
When subctl join is run against an OpenShift cluster with a deployed
cluster version operator, and service discovery is enabled, we now ask
for confirmation before continuing, because installing service
discovery will disable the CVO.

Fixes: #167
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit 9b6b450)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skitt skitt

Labels
lighthouse subctl Subctl related issues
Projects
None yet
Milestone
v0.1.1
2 participants
@mangelajo @skitt