Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subctl doesn’t pass K8s configs/contexts to kubectl and kubefedctl #180

Closed
skitt opened this issue Feb 18, 2020 · 0 comments · Fixed by #183
Closed

subctl doesn’t pass K8s configs/contexts to kubectl and kubefedctl #180

skitt opened this issue Feb 18, 2020 · 0 comments · Fixed by #183
Assignees
@skitt

Comments

@skitt
Copy link
Member

skitt commented Feb 18, 2020

In scenarios where subctl needs other tools (kubectl and kubefedctl, as used for Lighthouse), it doesn’t pass parameters to specify the configuration to use, so the whole setup only works if KUBECONFIG etc. are set appropriately externally.
@skitt skitt self-assigned this Feb 18, 2020
skitt added a commit to skitt/submariner-operator that referenced this issue Feb 19, 2020
@skitt
Provide config and context arguments to commands
cf7af2e 
Currently, subctl runs kubectl and kubefedctl in the default context:
whichever kubeconfig is the default, and whichever context is the
default. If the user specifies --kubeconfig and/or --kubecontext on
the subctl command-line, this causes mix-ups since subctl and the
other tools don’t touch the same cluster.

With this patch, kubectl and kubefedctl are given the appropriate
flags as necessary. This isn’t particularly elegant but it will all be
removed once KubeFed is removed.

Fixes: submariner-io#180
Signed-off-by: Stephen Kitt <skitt@redhat.com>
skitt added a commit to skitt/submariner-operator that referenced this issue Feb 19, 2020
@skitt
Provide config and context arguments to commands
67191c6 
Currently, subctl runs kubectl and kubefedctl in the default context:
whichever kubeconfig is the default, and whichever context is the
default. If the user specifies --kubeconfig and/or --kubecontext on
the subctl command-line, this causes mix-ups since subctl and the
other tools don’t touch the same cluster.

With this patch, kubectl and kubefedctl are given the appropriate
flags as necessary. This isn’t particularly elegant but it will all be
removed once KubeFed is removed.

Fixes: submariner-io#180
Signed-off-by: Stephen Kitt <skitt@redhat.com>
@skitt skitt mentioned this issue Feb 19, 2020
Merged
skitt added a commit to skitt/submariner-operator that referenced this issue Feb 20, 2020
@skitt
Provide config and context arguments to commands
0e0de8d 
Currently, subctl runs kubectl and kubefedctl in the default context:
whichever kubeconfig is the default, and whichever context is the
default. If the user specifies --kubeconfig and/or --kubecontext on
the subctl command-line, this causes mix-ups since subctl and the
other tools don’t touch the same cluster.

With this patch, kubectl and kubefedctl are given the appropriate
flags as necessary. This isn’t particularly elegant but it will all be
removed once KubeFed is removed.

Fixes: submariner-io#180
Signed-off-by: Stephen Kitt <skitt@redhat.com>
skitt added a commit to skitt/submariner-operator that referenced this issue Feb 21, 2020
@skitt
Provide config and context arguments to commands
dcdb386 
Currently, subctl runs kubectl and kubefedctl in the default context:
whichever kubeconfig is the default, and whichever context is the
default. If the user specifies --kubeconfig and/or --kubecontext on
the subctl command-line, this causes mix-ups since subctl and the
other tools don’t touch the same cluster.

With this patch, kubectl and kubefedctl are given the appropriate
flags as necessary. This isn’t particularly elegant but it will all be
removed once KubeFed is removed.

Fixes: submariner-io#180
Signed-off-by: Stephen Kitt <skitt@redhat.com>
skitt added a commit that referenced this issue Feb 24, 2020
@skitt
Provide config and context arguments to commands
731c52b 
Currently, subctl runs kubectl and kubefedctl in the default context:
whichever kubeconfig is the default, and whichever context is the
default. If the user specifies --kubeconfig and/or --kubecontext on
the subctl command-line, this causes mix-ups since subctl and the
other tools don’t touch the same cluster.

With this patch, kubectl and kubefedctl are given the appropriate
flags as necessary. This isn’t particularly elegant but it will all be
removed once KubeFed is removed.

Fixes: #180
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skitt skitt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Provide config and context arguments to commands skitt/submariner-operator
1 participant
@skitt