-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add skeleton for contribution guide (contribution section) #708
Conversation
🤖 Created branch: z_pr708/mkolesnik/devel-guide |
✔️ Deploy Preview for elated-bell-2913d9 ready! 🔨 Explore the source changes: 66fa44a 🔍 Inspect the deploy log: https://app.netlify.com/sites/elated-bell-2913d9/deploys/62309f8e22f81500090c3133 😎 Browse the preview: https://deploy-preview-708--elated-bell-2913d9.netlify.app |
b57f18b
to
3a16b8c
Compare
Half the guides in "Development" section are general contribution guidelines, it makes sense to split them to their own section. Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>
This guide outlines the Submariner release process, and how developers are expected to contribute. This is merely a skeletal outline which will be filled in following commits. Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>
FYI |
What's the difference between "Contribution" and "Development"? Isn't "Development" a subset of "Contribution"? I think we used to have a Contribution section and merged it with Development because we didn't have an obvious split between the two, were adding confusion about where to find/put things. I think we should talk about the goal here with a broader set of folks before putting too much more work into this. |
In general, if we want to do docs structure refactoring, this is the currently-agreed-on goal: submariner-io/enhancements#21 |
As stated in the commit message for the split:
The difference is between guidelines, and detailed guides how to do some things (backport, shipyard, etc).
No, there used to be a "Contributing" section which was changed to "For Developers" but it had all this content lumped together.
This is up for review, there's not "much more" work the split is in the first commit, I don't see why it can't be discussed here. We're defining general guidelines for working in Submariner, and the ask (which makes a lot of sense) was document it in the website instead of obscure docs. |
So should the Community Code of Conduct be under that? Getting Help? It's not clear to me that "Contributing=general guidelines" and "Development=detailed guides". |
Code of conduct is very general and not relates just to contribution guidelines. However, "Contributor Roles" definitely does and should move here as well, and part of the "Roadmap" should be here as well (and will be deleted anyway when we flesh out the guidelines).
If you have better names I'm open to suggestions, we can always change names later anyhow but my main point was that these two categories are essentially different groups of content which have been historically (for some or other reason) lumped into one mixed category. |
I prefer the approach of splitting the development process / cycle from the technical guides of how to do things |
I'd like to see a proposal for the structure suggestions that can be discussed more widely, and then implement that structure in one change, vs trying to restructure the website for the sake of adding this one section. |
Ideally, I'd like the enhancement proposal on exactly this topic to get this attention: submariner-io/enhancements#21 |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
🤖 Closed branches: [z_pr708/mkolesnik/devel-guide] |
This guide outlines the Submariner release process, and how developers
are expected to contribute.
This is merely a skeletal outline which will be filled in following
commits.
Signed-off-by: Mike Kolesnik mkolesni@redhat.com