Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skeleton for contribution guide (contribution section) #708

Closed
wants to merge 2 commits into from

Conversation

mkolesnik
Copy link
Contributor

This guide outlines the Submariner release process, and how developers
are expected to contribute.

This is merely a skeletal outline which will be filled in following
commits.

Signed-off-by: Mike Kolesnik mkolesni@redhat.com

@submariner-bot
Copy link

🤖 Created branch: z_pr708/mkolesnik/devel-guide

@netlify
Copy link

netlify bot commented Mar 15, 2022

✔️ Deploy Preview for elated-bell-2913d9 ready!

🔨 Explore the source changes: 66fa44a

🔍 Inspect the deploy log: https://app.netlify.com/sites/elated-bell-2913d9/deploys/62309f8e22f81500090c3133

😎 Browse the preview: https://deploy-preview-708--elated-bell-2913d9.netlify.app

@mkolesnik mkolesnik force-pushed the devel-guide branch 2 times, most recently from b57f18b to 3a16b8c Compare March 15, 2022 13:21
Half the guides in "Development" section are general contribution
guidelines, it makes sense to split them to their own section.

Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>
This guide outlines the Submariner release process, and how developers
are expected to contribute.

This is merely a skeletal outline which will be filled in following
commits.

Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>
@mkolesnik
Copy link
Contributor Author

mkolesnik commented Mar 15, 2022

FYI markdownlinks fails because of new "contribution" section which obviously isn't published yet, it should go back to normal once the PR merges
If necessary I'll happily add an ignore pattern which we'll have to revert after the merge

@dfarrell07
Copy link
Member

What's the difference between "Contribution" and "Development"? Isn't "Development" a subset of "Contribution"?

I think we used to have a Contribution section and merged it with Development because we didn't have an obvious split between the two, were adding confusion about where to find/put things.

I think we should talk about the goal here with a broader set of folks before putting too much more work into this.

@dfarrell07
Copy link
Member

In general, if we want to do docs structure refactoring, this is the currently-agreed-on goal: submariner-io/enhancements#21

@mkolesnik
Copy link
Contributor Author

What's the difference between "Contribution" and "Development"? Isn't "Development" a subset of "Contribution"?

As stated in the commit message for the split:

    Half the guides in "Development" section are general contribution
    guidelines, it makes sense to split them to their own section.

The difference is between guidelines, and detailed guides how to do some things (backport, shipyard, etc).
The first is guidelines to follow, and the second is "how-tos" for specific stuff.
If you have better distinguishable names I don't mind using them.

I think we used to have a Contribution section and merged it with Development because we didn't have an obvious split between the two, were adding confusion about where to find/put things.

No, there used to be a "Contributing" section which was changed to "For Developers" but it had all this content lumped together.

I think we should talk about the goal here with a broader set of folks before putting too much more work into this.

This is up for review, there's not "much more" work the split is in the first commit, I don't see why it can't be discussed here.

We're defining general guidelines for working in Submariner, and the ask (which makes a lot of sense) was document it in the website instead of obscure docs.
As part of this work, it made sense to put all guidelines in their own distinguishable section, since youre expected to follow them all, but "Development" section contains content which is not relevant to that.

@dfarrell07
Copy link
Member

dfarrell07 commented Mar 16, 2022

The first is guidelines to follow

So should the Community Code of Conduct be under that? Getting Help?

It's not clear to me that "Contributing=general guidelines" and "Development=detailed guides".

@mkolesnik
Copy link
Contributor Author

So should the Community Code of Conduct be under that? Getting Help?

Code of conduct is very general and not relates just to contribution guidelines.

However, "Contributor Roles" definitely does and should move here as well, and part of the "Roadmap" should be here as well (and will be deleted anyway when we flesh out the guidelines).

It's not clear to me that "Contributing=general guidelines" and "Development=detailed guides".

If you have better names I'm open to suggestions, we can always change names later anyhow but my main point was that these two categories are essentially different groups of content which have been historically (for some or other reason) lumped into one mixed category.

@mkolesnik mkolesnik changed the title Add skeleton for contribution guide Add skeleton for contribution guide (contribution section) Mar 16, 2022
@maayanf24
Copy link
Contributor

I prefer the approach of splitting the development process / cycle from the technical guides of how to do things

@dfarrell07
Copy link
Member

I'd like to see a proposal for the structure suggestions that can be discussed more widely, and then implement that structure in one change, vs trying to restructure the website for the sake of adding this one section.

@dfarrell07
Copy link
Member

Ideally, I'd like the enhancement proposal on exactly this topic to get this attention: submariner-io/enhancements#21

@stale
Copy link

stale bot commented Apr 2, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 2, 2022
@mkolesnik mkolesnik closed this Apr 3, 2022
@submariner-bot
Copy link

🤖 Closed branches: [z_pr708/mkolesnik/devel-guide]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants