Honor publishNotReadyAddresses flag for headless services #2646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lighthouse honors this flag when publishing endpoint addresses so Globalnet needs to as well when allocating a global IP for ingress. Fixes submariner-io/lighthouse#1342 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
tpantelis
requested review from
Oats87,
skitt and
sridhargaddam
as code owners
|
🤖 Created branch: z_pr2646/tpantelis/globalip_pod_not_ready |
aswinsuryan
approved these changes
Aug 11, 2023
sridhargaddam
approved these changes
Aug 16, 2023
|
@tpantelis did we add a release note when the Lighthouse change got merged? |
skitt
approved these changes
Aug 16, 2023
|
dfarrell07
approved these changes
Aug 16, 2023
|
🤖 Closed branches: [z_pr2646/tpantelis/globalip_pod_not_ready] |
dfarrell07
added
the
release-note-needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lighthouse honors this flag when publishing endpoint addresses so Globalnet needs to as well when allocating a global IP for ingress.
Fixes submariner-io/lighthouse#1342