Delete legacy non-IC static routes #2675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a deployment moves from non IC to IC, it may still have old static routes pointing to old nextHop. Remove such stale flows. This also adds following changes to make it easy to troubleshoot issues caused by stale flows/static-routes: * Set `external-id:submariner` to <version> instead of `true`. This will help with detecting stale flows from earlier deployment in future. * Set `external-id:submariner` for static routes. In future this will provide a better check to find routes/policies created by submariner. Signed-off-by: Vishal Thapar <5137689+vthapar@users.noreply.github.com>
vthapar
requested review from
Oats87,
skitt,
sridhargaddam and
tpantelis
as code owners
|
🤖 Created branch: z_pr2675/vthapar/ovn-stale-flows |
aswinsuryan
approved these changes
Sep 7, 2023
sridhargaddam
approved these changes
Sep 8, 2023
|
🤖 Closed branches: [z_pr2675/vthapar/ovn-stale-flows] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a deployment moves from non IC to IC, it may still have old static routes pointing to old nextHop. Remove such stale flows.
This also adds following changes to make it easy to troubleshoot issues caused by stale flows/static-routes:
external-id:submarinerto <version> instead oftrue. This will help with detecting stale flows from earlier deployment in future.external-id:submarinerfor static routes. In future this will provide a better check to find routes/policies created by submariner.