Allow halting on certificate errors #2761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skitt
requested review from
Oats87,
sridhargaddam and
tpantelis
as code owners
|
🤖 Created branch: z_pr2761/skitt/fatal-certificate-errors |
|
Let’s wait for submariner-io/admiral#767 instead (if deemed appropriate). |
skitt
force-pushed
the
fatal-certificate-errors
branch
from
274b08d to
0480578
Compare
skitt
added
the
backport
skitt
force-pushed
the
fatal-certificate-errors
branch
3 times, most recently
from
970ef4c to
70123a9
Compare
|
This PR/issue depends on:
|
skitt
force-pushed
the
fatal-certificate-errors
branch
from
70123a9 to
c0959d1
Compare
skitt
force-pushed
the
fatal-certificate-errors
branch
from
c0959d1 to
0b70cfc
Compare
When certificate errors are encountered, the fix is usually to restart the affected pod. To allow this to happen automatically, add a configuration setting for the gateway agent; extend the mechanism to the route agent. The setting is disabled by default; it will be enabled by default by the operator. Signed-off-by: Stephen Kitt <skitt@redhat.com>
skitt
force-pushed
the
fatal-certificate-errors
branch
from
0b70cfc to
f68ec6f
Compare
sridhargaddam
approved these changes
Oct 25, 2023
tpantelis
approved these changes
Oct 25, 2023
|
🤖 Closed branches: [z_pr2761/skitt/fatal-certificate-errors] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When certificate errors are encountered, the fix is usually to restart the affected pod. To allow this to happen automatically, add a configuration setting for the gateway agent.
The setting is disabled by default; it will be enabled by default by the operator.
Depends on submariner-io/admiral#767