From e19923cd0fa97dc1f9d26a3b36f38fe0de6b825d Mon Sep 17 00:00:00 2001
From: Nic Crane <thisisnic@gmail.com>
Date: Fri, 12 Aug 2022 11:49:28 +0100
Subject: [PATCH 1/2] feat: add log1p function

---
 extensions/functions_logarithmic.yaml | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/extensions/functions_logarithmic.yaml b/extensions/functions_logarithmic.yaml
index 8f9925c28..57b71b6d2 100644
--- a/extensions/functions_logarithmic.yaml
+++ b/extensions/functions_logarithmic.yaml
@@ -102,5 +102,29 @@ scalar_functions:
             name: "base"
             description: "The logarithm base `b` to use"
         return: fp64
+  -
+    name: "log1p"
+    description: >
+      Natural logarithm (base e) of 1 + the value
 
+      log1p(x) => log(1+x)
+    impls:
+      - args:
+          - name: rounding
+            options: [ TIE_TO_EVEN, TIE_AWAY_FROM_ZERO, TRUNCATE, CEILING, FLOOR ]
+            required: false
+          - name: on_domain_error
+            options: [ NAN, ERROR ]
+            required: false
+          - value: fp32
+        return: fp32
+      - args:
+          - name: rounding
+            options: [ TIE_TO_EVEN, TIE_AWAY_FROM_ZERO, TRUNCATE, CEILING, FLOOR ]
+            required: false
+          - name: on_domain_error
+            options: [ NAN, ERROR ]
+            required: false
+          - value: fp64
+        return: fp64
 

From 77711aa8bdb9fe53a49f79f48e1b704ab9a51417 Mon Sep 17 00:00:00 2001
From: Nic Crane <thisisnic@gmail.com>
Date: Thu, 1 Sep 2022 14:57:27 +0100
Subject: [PATCH 2/2] docs: add names to log1p input args

---
 extensions/functions_logarithmic.yaml | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/extensions/functions_logarithmic.yaml b/extensions/functions_logarithmic.yaml
index 57b71b6d2..e8cc43ae9 100644
--- a/extensions/functions_logarithmic.yaml
+++ b/extensions/functions_logarithmic.yaml
@@ -105,7 +105,7 @@ scalar_functions:
   -
     name: "log1p"
     description: >
-      Natural logarithm (base e) of 1 + the value
+      Natural logarithm (base e) of 1 + x
 
       log1p(x) => log(1+x)
     impls:
@@ -116,7 +116,8 @@ scalar_functions:
           - name: on_domain_error
             options: [ NAN, ERROR ]
             required: false
-          - value: fp32
+          - name: x
+            value: fp32
         return: fp32
       - args:
           - name: rounding
@@ -125,6 +126,7 @@ scalar_functions:
           - name: on_domain_error
             options: [ NAN, ERROR ]
             required: false
-          - value: fp64
+          - name: x
+            value: fp64
         return: fp64