From 9056da888121e96cefd4769d21a92ec0247bb8df Mon Sep 17 00:00:00 2001
From: Vibhatha Abeykoon <vibhatha@gmail.com>
Date: Tue, 23 Aug 2022 12:49:05 +0530
Subject: [PATCH 1/3] feat(string_agg): initial commit

---
 extensions/functions_string.yaml | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/extensions/functions_string.yaml b/extensions/functions_string.yaml
index 220755e45..c2d1b5e1c 100644
--- a/extensions/functions_string.yaml
+++ b/extensions/functions_string.yaml
@@ -1263,3 +1263,18 @@ scalar_functions:
           - value: i32
             name: "count"
         return: "string"
+
+aggregate_functions:
+
+  -
+    name: string_agg
+    description: Concatenates a column of string values with a separator.
+    impls:
+      - args:
+          - value: "varchar<L1>"
+            name: "input"
+            description: "Column of string values."
+          - value: "varchar<L2>"
+            name: "separator"
+            description: "Separator for concatenated strings"
+        return: "varchar<L1 + L2>"
\ No newline at end of file

From 9a564761d132b040aade19f9b437ab9047991720 Mon Sep 17 00:00:00 2001
From: Vibhatha Abeykoon <vibhatha@gmail.com>
Date: Fri, 26 Aug 2022 11:05:06 +0530
Subject: [PATCH 2/3] fix(type): replaced varchar with string

---
 extensions/functions_string.yaml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/extensions/functions_string.yaml b/extensions/functions_string.yaml
index c2d1b5e1c..abaa07294 100644
--- a/extensions/functions_string.yaml
+++ b/extensions/functions_string.yaml
@@ -1271,10 +1271,10 @@ aggregate_functions:
     description: Concatenates a column of string values with a separator.
     impls:
       - args:
-          - value: "varchar<L1>"
+          - value: "string"
             name: "input"
             description: "Column of string values."
-          - value: "varchar<L2>"
+          - value: "string"
             name: "separator"
             description: "Separator for concatenated strings"
-        return: "varchar<L1 + L2>"
\ No newline at end of file
+        return: "string"
\ No newline at end of file

From 8214c20f82c1ba3cffb4fd6083f60d34c68f9b41 Mon Sep 17 00:00:00 2001
From: Vibhatha Abeykoon <vibhatha@gmail.com>
Date: Mon, 5 Sep 2022 05:49:04 +0530
Subject: [PATCH 3/3] fix(review): added constant field

---
 extensions/functions_string.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/extensions/functions_string.yaml b/extensions/functions_string.yaml
index abaa07294..f37b914c5 100644
--- a/extensions/functions_string.yaml
+++ b/extensions/functions_string.yaml
@@ -1276,5 +1276,6 @@ aggregate_functions:
             description: "Column of string values."
           - value: "string"
             name: "separator"
+            constant: true
             description: "Separator for concatenated strings"
         return: "string"
\ No newline at end of file