feat: runtime instruction/syscall report #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
counts instructions and syscalls
puma314
approved these changes
May 30, 2024
| } | ||
|
|
||
| #[derive(Default, Debug, Clone, PartialEq, Eq)] | ||
| pub struct InstructionReport { |
There was a problem hiding this comment.
I thin that we should implement a string formatting method on this, so we can print it out (and have the opcode pretty printed out) and also a pretty version of the syscall code
|
looks good, but please merge into succinctlabs:dev branch instead of main |
|
merging although FYI u64 is more appropriate for cycle counts as we already have some programs close to u32 cap, will fix in a follow up PR |
mattstam
pushed a commit
that referenced
this pull request
May 30, 2024
Co-authored-by: Ratan Kaliani <ratankaliani@berkeley.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Counts instructions and syscalls by their opcode/syscall code when
should_reportis set (currently always).