feat: execute() exposes ExecutionReport #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattstam
commented
May 30, 2024
mattstam
commented
May 30, 2024
ctian1
requested changes
May 30, 2024
core/src/runtime/mod.rs
Outdated
| self.total_instruction_count() | ||
| )?; | ||
| write!(f, "Syscall Counts:\n")?; | ||
| for (syscall, count) in &self.syscall_counts { |
There was a problem hiding this comment.
it'd be nice to sort this in alphabetical order so its consistent
There was a problem hiding this comment.
Instruction Counts:
add: 583439
and: 151701
auipc: 19488
beq: 26917
bge: 237
bgeu: 5917
blt: 1141
bltu: 43457
bne: 51442
divu: 6
ecall: 2264
jal: 5372
jalr: 38749
lb: 10723
lbu: 57950
lw: 237094
mul: 4036
mulhu: 1152
or: 301944
sb: 58448
sll: 278698
sltu: 16766
srl: 293010
sub: 12382
sw: 312781
xor: 242242
Total Instructions: 2757356
Syscall Counts:
COMMIT: 8
COMMIT_DEFERRED_PROOFS: 8
HALT: 1
SHA_COMPRESS: 1091
SHA_EXTEND: 1091
WRITE: 65
Total Syscall Count: 2264
There was a problem hiding this comment.
the difference in lower vs upper case is annoying, is it fine if I re-write all the Opcode enums
sp1/core/src/runtime/opcode.rs
Line 72 in dbed499
There was a problem hiding this comment.
can you just do .to_uppercase()? also it looks fine imo
There was a problem hiding this comment.
for consistency, should we show 0 for the missing ones?
ctian1
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows callers can check cycles, also removes cycle check / simulation from proof requests