Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set core opts from SHARD* env vars #889

Merged
merged 1 commit into from
Jun 7, 2024
Merged

fix: set core opts from SHARD* env vars #889

merged 1 commit into from
Jun 7, 2024

Conversation

chiefbiiko
Copy link
Contributor

Reads runtime env vars SHARD_SIZE and SHARD_BATCH_SIZE into SP1CoreOpts::default(). It seems they just weren't applied before.

@chiefbiiko
Copy link
Contributor Author

For some reason though, increasing the SHARD* envs doesn't yield any performance improvements for my program..

@chiefbiiko chiefbiiko changed the base branch from main to dev June 5, 2024 13:14
@jtguibas jtguibas merged commit 0377fcb into succinctlabs:dev Jun 7, 2024
5 checks passed
@wwared wwared mentioned this pull request Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtguibas jtguibas jtguibas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chiefbiiko @jtguibas