CXP-3032: Race condition during local.buffer.dir creation
#43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multiple tasks are starte on the same worker all of them are trying to check if the directory exists and create if not. Sometimes some of the tasks fail because the directory gets created after the existence check and before the creation attempt by other tasks. The fix is to do a few attempts of checking and creating the directory.
| if (!directory.exists() && !directory.mkdirs()) { | ||
| int attempts = 3; | ||
| while (attempts > 0 && !directory.exists() && !directory.mkdirs()) { | ||
| attempts--; |
There was a problem hiding this comment.
Does it really work without sleep?
There was a problem hiding this comment.
Sleep won't change anything here. By the time it fails, the directory already exists: the adjacent task on the same worker is faster with creating it.
mikekamornikov
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple tasks are starte on the same worker all of them are trying to check if the directory exists and create if not. Sometimes some of the tasks fail because the directory gets created after the existence check and before the creation attempt by other tasks.
The fix is to do a few attempts of checking and creating the directory.