diff --git a/CHANGELOG.md b/CHANGELOG.md index f96dee4db1..886ff22575 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,12 +8,13 @@ and this project adheres to ## [Unreleased] -- ⚡️(frontend) improve accessibility: - - #1341 - ### Added - ✨(api) add API route to fetch document content #1206 +- ♿(frontend) improve accessibility: + - #1349 + - #1271 + - #1341 ### Changed @@ -41,7 +42,6 @@ and this project adheres to - ♿(frontend) improve accessibility for decorative images in editor #1282 - #1338 - #1281 - - #1271 - ♻️(backend) fallback to email identifier when no name #1298 - 🐛(backend) allow ASCII characters in user sub field #1295 - ⚡️(frontend) improve fallback width calculation #1333 diff --git a/src/frontend/apps/e2e/__tests__/app-impress/doc-editor.spec.ts b/src/frontend/apps/e2e/__tests__/app-impress/doc-editor.spec.ts index cdfa6ccc77..ca4053c672 100644 --- a/src/frontend/apps/e2e/__tests__/app-impress/doc-editor.spec.ts +++ b/src/frontend/apps/e2e/__tests__/app-impress/doc-editor.spec.ts @@ -463,12 +463,14 @@ test.describe('Doc Editor', () => { await expect( page.getByRole('button', { name: 'Download', + exact: true, }), ).toBeVisible(); void page .getByRole('button', { name: 'Download', + exact: true, }) .click(); diff --git a/src/frontend/apps/e2e/__tests__/app-impress/doc-export.spec.ts b/src/frontend/apps/e2e/__tests__/app-impress/doc-export.spec.ts index 6450da39b7..81a22f2cd6 100644 --- a/src/frontend/apps/e2e/__tests__/app-impress/doc-export.spec.ts +++ b/src/frontend/apps/e2e/__tests__/app-impress/doc-export.spec.ts @@ -38,7 +38,9 @@ test.describe('Doc Export', () => { ).toBeVisible(); await expect(page.getByRole('combobox', { name: 'Format' })).toBeVisible(); await expect( - page.getByRole('button', { name: 'Close the modal' }), + page.getByRole('button', { + name: 'Close the download modal', + }), ).toBeVisible(); await expect(page.getByTestId('doc-export-download-button')).toBeVisible(); }); diff --git a/src/frontend/apps/e2e/__tests__/app-impress/doc-grid.spec.ts b/src/frontend/apps/e2e/__tests__/app-impress/doc-grid.spec.ts index 1881541e95..59a1b998eb 100644 --- a/src/frontend/apps/e2e/__tests__/app-impress/doc-grid.spec.ts +++ b/src/frontend/apps/e2e/__tests__/app-impress/doc-grid.spec.ts @@ -149,7 +149,7 @@ test.describe('Document grid item options', () => { await page .getByRole('button', { - name: 'Confirm deletion', + name: 'Delete document', }) .click(); diff --git a/src/frontend/apps/e2e/__tests__/app-impress/doc-header.spec.ts b/src/frontend/apps/e2e/__tests__/app-impress/doc-header.spec.ts index c707163e08..7c7f7ddabc 100644 --- a/src/frontend/apps/e2e/__tests__/app-impress/doc-header.spec.ts +++ b/src/frontend/apps/e2e/__tests__/app-impress/doc-header.spec.ts @@ -100,7 +100,7 @@ test.describe('Doc Header', () => { await page .getByRole('button', { - name: 'Confirm deletion', + name: 'Delete document', }) .click(); diff --git a/src/frontend/apps/e2e/__tests__/app-impress/doc-search.spec.ts b/src/frontend/apps/e2e/__tests__/app-impress/doc-search.spec.ts index 412064dd31..60cff9a312 100644 --- a/src/frontend/apps/e2e/__tests__/app-impress/doc-search.spec.ts +++ b/src/frontend/apps/e2e/__tests__/app-impress/doc-search.spec.ts @@ -33,7 +33,7 @@ test.describe('Document search', () => { ).toBeVisible(); await expect( - page.getByLabel('Search modal').getByText('search'), + page.getByRole('heading', { name: 'Search docs' }), ).toBeVisible(); const inputSearch = page.getByPlaceholder('Type the name of a document'); @@ -79,7 +79,7 @@ test.describe('Document search', () => { await page.keyboard.press('Control+k'); await expect( - page.getByLabel('Search modal').getByText('search'), + page.getByRole('heading', { name: 'Search docs' }), ).toBeVisible(); await page.keyboard.press('Escape'); diff --git a/src/frontend/apps/impress/src/components/modal/AlertModal.tsx b/src/frontend/apps/impress/src/components/modal/AlertModal.tsx index ffee754cad..c1d038f089 100644 --- a/src/frontend/apps/impress/src/components/modal/AlertModal.tsx +++ b/src/frontend/apps/impress/src/components/modal/AlertModal.tsx @@ -30,15 +30,23 @@ export const AlertModal = ({ isOpen={isOpen} size={ModalSize.MEDIUM} onClose={onClose} + aria-describedby="alert-modal-title" title={ - + {title} } rightActions={ <>