Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover underline/color for links with icons #1311

Open
dbranchini opened this issue Aug 29, 2024 · 4 comments
Open

Hover underline/color for links with icons #1311

dbranchini opened this issue Aug 29, 2024 · 4 comments
Labels

Comments

@dbranchini
Copy link

@dnoneill and I talked about this, and it might not be easy to fix, but I thought I'd at least document it. Ideally, the text links with preceding icons should do the following on hover: underline the text (not the icons too -- see examples below), and both the icon and text should change from Digital blue #006CB8 to Digital blue Dark #00548f. Email looks correct in the examples below.

@dbranchini dbranchini converted this from a draft issue Aug 29, 2024
@dbranchini dbranchini added the ui label Aug 29, 2024
@dnoneill dnoneill self-assigned this Aug 29, 2024
@dnoneill dnoneill moved this from Ready to In Progress in Geo Workcycles 2024 Aug 29, 2024
@dnoneill dnoneill moved this from In Progress to In Review in Geo Workcycles 2024 Aug 29, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Geo Workcycles 2024 Aug 29, 2024
@dbranchini
Copy link
Author

The tools (top/right on record view) links are underlined by default, and they should only be underlined on hover (or we could use the default link styling, which is defined here https://www.figma.com/design/FE5WZAvHf2e97GJeOP3mH6/Stanford-Styles?node-id=243-72&t=jmVCbmGmAds0BtN2-4). Also, the underline under the icon is still there on "Back to search results."

@dbranchini dbranchini reopened this Aug 30, 2024
@dbranchini dbranchini moved this from Done to Ready in Geo Workcycles 2024 Aug 30, 2024
@dnoneill
Copy link
Contributor

@dbranchini All the figmas have them underlined.
Screenshot 2024-08-30 at 10 53 28 AM

@dnoneill dnoneill moved this from Ready to In Progress in Geo Workcycles 2024 Aug 30, 2024
@dnoneill
Copy link
Contributor

@dbranchini What I have found is it doesn't seem like we can get rid of that underline.

@dnoneill dnoneill moved this from In Progress to In Review in Geo Workcycles 2024 Aug 30, 2024
@dbranchini
Copy link
Author

Unfortunately, this presents an accessibility problem. It can't be color alone that distinguishes b/n states. A good compromise would be to use the dotted underline as the default and a solid underline as a hover state with the color change.

@dnoneill dnoneill moved this from In Review to Blocked in Geo Workcycles 2024 Sep 5, 2024
@dnoneill dnoneill removed their assignment Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Blocked
Development

No branches or pull requests

2 participants