-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hover underline/color for links with icons #1311
Comments
The tools (top/right on record view) links are underlined by default, and they should only be underlined on hover (or we could use the default link styling, which is defined here https://www.figma.com/design/FE5WZAvHf2e97GJeOP3mH6/Stanford-Styles?node-id=243-72&t=jmVCbmGmAds0BtN2-4). Also, the underline under the icon is still there on "Back to search results." |
@dbranchini All the figmas have them underlined. |
@dbranchini What I have found is it doesn't seem like we can get rid of that underline. |
Unfortunately, this presents an accessibility problem. It can't be color alone that distinguishes b/n states. A good compromise would be to use the dotted underline as the default and a solid underline as a hover state with the color change. |
@dnoneill and I talked about this, and it might not be easy to fix, but I thought I'd at least document it. Ideally, the text links with preceding icons should do the following on hover: underline the text (not the icons too -- see examples below), and both the icon and text should change from Digital blue
#006CB8
to Digital blue Dark#00548f
. Email looks correct in the examples below.The text was updated successfully, but these errors were encountered: