Install and configure tooling #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasnatter
force-pushed
the
enhancement/tooling
branch
from
dc03668 to
bed9e63
Compare
niklasnatter
force-pushed
the
enhancement/tooling
branch
from
bed9e63 to
b921bde
Compare
niklasnatter
changed the title
alexander-schranz
requested changes
Oct 7, 2019
| use Sulu\Component\Webspace\Webspace; | ||
| use Symfony\Component\HttpFoundation\Request; | ||
| use Symfony\Component\HttpKernel\Event\GetResponseEvent; | ||
|
|
||
| class SetThemeEventListenerTest extends TestCase | ||
| { | ||
| /** | ||
| * @var ActiveTheme | ||
| * @var ObjectProphecy> |
| @@ -38,7 +38,7 @@ public function __construct(ActiveTheme $activeTheme) | |||
| * | |||
| * @param GetResponseEvent $event | |||
| */ | |||
| public function setActiveThemeOnRequest(GetResponseEvent $event) | |||
| public function setActiveThemeOnRequest(GetResponseEvent $event): void | |||
There was a problem hiding this comment.
sorry this is a bc break we can not do this if not really needed use phpdocs instead.
There was a problem hiding this comment.
i decided that im willing to make this break 😜
niklasnatter
force-pushed
the
enhancement/tooling
branch
from
454a096 to
d1fa19e
Compare
niklasnatter
force-pushed
the
enhancement/tooling
branch
from
d1fa19e to
8559210
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR installs and configures our usual tooling stack: